[webkit-reviews] review granted: [Bug 195427] [Web GPU] GPUSampler implementation : [Attachment 363916] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 195427: [Web GPU] GPUSampler implementation
https://bugs.webkit.org/show_bug.cgi?id=195427

Attachment 363916: Patch

https://bugs.webkit.org/attachment.cgi?id=363916&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 363916
  --> https://bugs.webkit.org/attachment.cgi?id=363916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363916&action=review

> Source/WebCore/platform/graphics/gpu/GPUSamplerDescriptor.h:63
> +    AddressMode addressModeU = AddressMode::ClampToEdge;
> +    AddressMode addressModeV = AddressMode::ClampToEdge;
> +    AddressMode addressModeW = AddressMode::ClampToEdge;
> +    FilterMode magFilter = FilterMode::Nearest;
> +    FilterMode minFilter = FilterMode::Nearest;
> +    FilterMode mipmapFilter = FilterMode::Nearest;
> +    float lodMinClamp = 0;
> +    float lodMaxClamp = 0xffffffff;
> +    unsigned maxAnisotropy = 1;
> +    GPUCompareFunction compareFunction = GPUCompareFunction::Never;
> +    BorderColor borderColor = BorderColor::TransparentBlack;

Is there any difference between this syntax and using AddressMode addressModeU
{ AddressMode::ClampToEdge }; ?