[webkit-reviews] review granted: [Bug 195428] Follow up refactoring in try-finally code after r242591. : [Attachment 363920] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 195428: Follow up refactoring in try-finally code after r242591.
https://bugs.webkit.org/show_bug.cgi?id=195428

Attachment 363920: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=363920&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 363920
  --> https://bugs.webkit.org/attachment.cgi?id=363920
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363920&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4790
> +	       // 10: try {
> +	       // 11:	  for (... stuff ...) {
> +	       // 12:	      try {
> +	       // 13:		  continue; // Sets completionType to jumpID of
top of the for loop.
> +	       // 14:	      } finally {
> +	       // 15:	      } // Jump to top of the for loop on completion.
> +	       // 16:	  }
> +	       // 15: } finally {
> +	       // 16: }

remove line numbers

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4820
> +		   // 10: try {
> +		   // 11:     try {
> +		   // 12:	  return result; // Sets completionType to
Return, and completionValue to result.
> +		   // 13:     } finally {
> +		   // 14:     } // Jump to outer finally on completion.
> +		   // 15: } finally {
> +		   // 16: }

remove line numbers

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4888
> +		   // 10: try {
> +		   // 11:     return result; // Sets completionType to Return,
and completionValue to result.
> +		   // 12: } finally {
> +		   // 13: } // Executes the return of the completionValue.

remove line numbers.