[webkit-reviews] review granted: [Bug 195349] [Apple Pay] Untangle PKPaymentAuthorizationViewController from WebPaymentCoordinatorProxy : [Attachment 363808] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 11:24:31 PST 2019


Alex Christensen <achristensen at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 195349: [Apple Pay] Untangle PKPaymentAuthorizationViewController from
WebPaymentCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=195349

Attachment 363808: Patch

https://bugs.webkit.org/attachment.cgi?id=363808&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 363808
  --> https://bugs.webkit.org/attachment.cgi?id=363808
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363808&action=review

> Source/WebKit/Platform/cocoa/PaymentAuthorizationViewController.h:49
> +#if PLATFORM(IOS_FAMILY)
> +   
PaymentAuthorizationViewController(PaymentAuthorizationPresenter::Client&,
PKPaymentRequest *);
> +#endif
> +#if PLATFORM(MAC)
> +   
PaymentAuthorizationViewController(PaymentAuthorizationPresenter::Client&,
PKPaymentRequest *, PKPaymentAuthorizationViewController *);
> +#endif

This could be a default parameter.


More information about the webkit-reviews mailing list