[webkit-reviews] review granted: [Bug 195299] Web Inspector: REGRESSION(r242118): WI.ScopeBar missing background : [Attachment 363591] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 10:30:13 PST 2019

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195299: Web Inspector: REGRESSION(r242118): WI.ScopeBar missing background

Attachment 363591: Patch


--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363591
  --> https://bugs.webkit.org/attachment.cgi?id=363591

View in context: https://bugs.webkit.org/attachment.cgi?id=363591&action=review


> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:96
> +	       indicatorElement.classList.add("indicator");

Nit:`elem.className = "indicator"` is more common and faster for the simple
case where we just created the element and are setting classes.

> Source/WebInspectorUI/UserInterface/Views/MultipleScopeBarItem.js:178
>	   // Clicking when selected will cause the menu it appear instead.

Fix the typo in this comment while you're in the area. "menu it appear" =>
"menu to appear"

> Source/WebInspectorUI/UserInterface/Views/MultipleScopeBarItem.js:181
> +	   if (this._element.classList.contains("selected")) {
> +	       let newEvent = new event.constructor(event.type, event);
> +	       newEvent.__original = event;

This should really be its own separate change.

More information about the webkit-reviews mailing list