[webkit-reviews] review granted: [Bug 194810] Lazily decode cached bytecode : [Attachment 363558] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 194810: Lazily decode cached bytecode
https://bugs.webkit.org/show_bug.cgi?id=194810

Attachment 363558: Patch

https://bugs.webkit.org/attachment.cgi?id=363558&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 363558
  --> https://bugs.webkit.org/attachment.cgi?id=363558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363558&action=review

> Source/JavaScriptCore/runtime/CachedTypes.cpp:2016
> +	   if (!cachedExecutable.unlinkedCodeBlockForCall().isEmpty())

Don’t you want to zero out these offsets if this check is falsey?