[webkit-reviews] review granted: [Bug 195396] [iOS WK] REGRESSION (r242132): Fixed position banners flicker and move when scrolling (Apple, Tesla, YouTube, Reddit) : [Attachment 363877] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 09:11:09 PST 2019


Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 195396: [iOS WK] REGRESSION (r242132): Fixed position banners flicker and
move when scrolling (Apple, Tesla, YouTube, Reddit)
https://bugs.webkit.org/show_bug.cgi?id=195396

Attachment 363877: Patch

https://bugs.webkit.org/attachment.cgi?id=363877&action=review




--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 363877
  --> https://bugs.webkit.org/attachment.cgi?id=363877
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363877&action=review

Ok but please test well before landing.

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:187
> +    bool scrollPositionChanged =
!scrollPositionAndLayoutViewportMatch(position, overrideLayoutViewport);

This is not just a rename, you invert the logic from the previous patch. This
raises questions about testing.


More information about the webkit-reviews mailing list