[webkit-reviews] review granted: [Bug 195359] [GTK] Make Tools/gtkdoc/ python3 compatible : [Attachment 363871] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 195359: [GTK] Make Tools/gtkdoc/ python3 compatible
https://bugs.webkit.org/show_bug.cgi?id=195359

Attachment 363871: Patch

https://bugs.webkit.org/attachment.cgi?id=363871&action=review




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 363871
  --> https://bugs.webkit.org/attachment.cgi?id=363871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363871&action=review

> Tools/gtkdoc/generate-gtkdoc:120
> +    if sys.version_info < (3, 2):
> +	   config = SafeConfigParser();
> +    else:
> +	   config = configparser.ConfigParser()

Could we do something like:

from ConfigParser import SafeConfigParser as ConfigParser

and

from configparser import ConfigParser

and then we don't need to check version here again?