[webkit-reviews] review granted: [Bug 195392] Exception is a JSCell, not a JSObject. : [Attachment 363848] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 23:32:19 PST 2019

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 195392: Exception is a JSCell, not a JSObject.

Attachment 363848: proposed patch.


--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 363848
  --> https://bugs.webkit.org/attachment.cgi?id=363848
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363848&action=review

> Source/JavaScriptCore/ChangeLog:31
> +	      We'll leave these as is for now.	To facilitate the conversion
from Exception*

I don’t understand why you need anything special here. We already define

> Source/JavaScriptCore/runtime/JSCJSValueInlines.h:189
> +inline JSValue::JSValue(Exception* exception)

This isn’t needed

> Source/JavaScriptCore/runtime/JSCast.h:36
> +    if (!(!from || from->JSCell::inherits(*from->JSCell::vm(),
std::remove_pointer<To>::type::info()))) {


More information about the webkit-reviews mailing list