[webkit-reviews] review granted: [Bug 182216] [ESNext][BigInt] Implement "~" unary operation : [Attachment 363089] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 182216: [ESNext][BigInt] Implement "~" unary operation
https://bugs.webkit.org/show_bug.cgi?id=182216

Attachment 363089: Patch

https://bugs.webkit.org/attachment.cgi?id=363089&action=review




--- Comment #35 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 363089
  --> https://bugs.webkit.org/attachment.cgi?id=363089
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363089&action=review

r=me with some comments.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:384
> +	       if (node->child1().useKind() == UntypedUse)
> +		   didFoldClobberWorld();

Why do you need this check? It doesn't seem like you should need it because
even if Fixup thinks this should have been a BigInt, AI has proven it's an
int32.

> Source/JavaScriptCore/dfg/DFGOperations.cpp:216
> +template<typename BigIntOperation, typename Int32Operation>
> +static ALWAYS_INLINE EncodedJSValue bitwiseBinaryOp(ExecState* exec,
EncodedJSValue encodedOp1, EncodedJSValue encodedOp2, BigIntOperation&&
bigIntOp, Int32Operation&& int32Op, const char* errorMessage)

Nice!

> JSTests/stress/big-int-bit-not-general.js:4
> +// Copyright (C) 2017 Josh Wolfe. All rights reserved.
> +// This code is governed by the BSD license found in the LICENSE file.

Does this file exist? If not please paste the contents of the original BSD
license here.