[webkit-reviews] review denied: [Bug 195266] Web Inspector: Audit: provide a way to get the contents of resources : [Attachment 363713] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195266: Web Inspector: Audit: provide a way to get the contents of
resources
https://bugs.webkit.org/show_bug.cgi?id=195266

Attachment 363713: Patch

https://bugs.webkit.org/attachment.cgi?id=363713&action=review




--- Comment #18 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363713
  --> https://bugs.webkit.org/attachment.cgi?id=363713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363713&action=review

>> Source/WebCore/inspector/InspectorAuditResourcesObject.h:58
>> +	ExceptionOr<Vector<Resource>> getContents(Document&,
Optional<QueryOptions>);
> 
> One drawback of having this be one API instead of two is that if you want all
the resources you get an enormous JSON result with the contents of all
resources. In fact, building that JSON might blow up the memory of inspected
page.
> 
> We could have this be two APIs:
> 
>     getResources(query?)
>     getResourceContent(url|id)
> 
> This is also nicer for developers to get the complete list of URLs/MIMETypes
and filter them by RegExp on their own.
> 
> What do you think about this approach?

I'm going to r- while we discuss this aspect, I think this is a better API.

Also maybe we should make these asynchronous, but everyone enjoys the
simplicity of synchronous APIs.