[webkit-reviews] review granted: [Bug 195214] Crash in com.apple.WebCore: WebCore::IDBTransaction::pendingOperationTimerFired + 72 : [Attachment 363714] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 195214: Crash in com.apple.WebCore:
WebCore::IDBTransaction::pendingOperationTimerFired + 72
https://bugs.webkit.org/show_bug.cgi?id=195214

Attachment 363714: Patch

https://bugs.webkit.org/attachment.cgi?id=363714&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 363714
  --> https://bugs.webkit.org/attachment.cgi?id=363714
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363714&action=review

r=me

> Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144
> +    bool m_doneComplete { false };

We usually use 'did' instead of 'done'. So, I would name this 'm_didComplete'.