[webkit-reviews] review granted: [Bug 195186] JSScript should keep the cache file locked for the duration of its existence and should truncate the cache when it is out of date : [Attachment 363564] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 195186: JSScript should keep the cache file locked for the duration of its
existence and should truncate the cache when it is out of date
https://bugs.webkit.org/show_bug.cgi?id=195186

Attachment 363564: patch

https://bugs.webkit.org/attachment.cgi?id=363564&action=review




--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 363564
  --> https://bugs.webkit.org/attachment.cgi?id=363564
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363564&action=review

r=me.

> Source/JavaScriptCore/API/JSScript.mm:54
> -    UniquedStringImpl* m_moduleKey;
> +    int m_cacheFileDescriptor;

Can you use C++ initializers here? e.g. { -1 }