[webkit-reviews] review granted: [Bug 195377] Web Inspector: DOM Debugger: event breakpoints still fire when breakpoints are disabled : [Attachment 363797] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 15:09:39 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195377: Web Inspector: DOM Debugger: event breakpoints still fire when
breakpoints are disabled
https://bugs.webkit.org/show_bug.cgi?id=195377

Attachment 363797: Patch

https://bugs.webkit.org/attachment.cgi?id=363797&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363797
  --> https://bugs.webkit.org/attachment.cgi?id=363797
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363797&action=review

r=me, nice!

> LayoutTests/inspector/dom-debugger/event-listener-breakpoints-expected.txt:94
> +PASS: Should only pause once.

Maybe "Should only have paused once."


More information about the webkit-reviews mailing list