[webkit-reviews] review granted: [Bug 195379] [macOS] Sandbox call violation causes WebContent process to crash : [Attachment 363794] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 14:33:40 PST 2019

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 195379: [macOS] Sandbox call violation causes WebContent process to crash

Attachment 363794: Patch


--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 363794
  --> https://bugs.webkit.org/attachment.cgi?id=363794

View in context: https://bugs.webkit.org/attachment.cgi?id=363794&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972
> +	   (syscall-number SYS_memorystatus_control)

I suggest you add a comment with the Radar#, or perhaps the reason we need to
include this (e.g., list which Framework uses it.)

I this case, I think it night be:

"..._control) ;; Needed for memory measurement infrastructure"

Or something like that.

More information about the webkit-reviews mailing list