[webkit-reviews] review canceled: [Bug 195342] [iOS] Block the accessibility server when accessibility is not enabled. : [Attachment 363771] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has canceled Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 195342: [iOS] Block the accessibility server when accessibility is not
enabled.
https://bugs.webkit.org/show_bug.cgi?id=195342

Attachment 363771: Patch

https://bugs.webkit.org/attachment.cgi?id=363771&action=review




--- Comment #19 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 363771
  --> https://bugs.webkit.org/attachment.cgi?id=363771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363771&action=review

> Source/WebKit/Shared/mac/SandboxExtensionMac.mm:93
> +	       return
sandbox_extension_issue_mach_to_process_by_pid("com.apple.webkit.extension.mach
", path, 0, pid.value());

Should this be "com.apple.webkit.extensions.mach"_s, since it's a String being
passed?

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:429
> +    m_accessibilityEnabledObserver = [[NSNotificationCenter defaultCenter]
addObserverForName:(__bridge id)kAXSApplicationAccessibilityEnabledNotification
object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification
*note) {

Should we add an UNUSED_PARAM(note) here?