[webkit-reviews] review granted: [Bug 195300] Move RenderObject::isTransparentOrFullyClippedRespectingParentFrames() to RenderLayer : [Attachment 363759] Typo fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 10:57:49 PST 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 195300: Move
RenderObject::isTransparentOrFullyClippedRespectingParentFrames() to
RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=195300

Attachment 363759: Typo fix

https://bugs.webkit.org/attachment.cgi?id=363759&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 363759
  --> https://bugs.webkit.org/attachment.cgi?id=363759
Typo fix

View in context: https://bugs.webkit.org/attachment.cgi?id=363759&action=review

> Source/WebCore/ChangeLog:8
> +	   Move `isTransparentOrFullyClippedRespectingParentFrames()` from
RenderObject to RenderLayer, since this function

Backticks :\

> Source/WebCore/rendering/RenderLayer.cpp:6602
> +bool RenderLayer::isTransparentOrFullyClippedRespectingParentFrames() const

It strikes me that this potentially allows an iframe to learn things about its
enclosing frames which is bad from a security perspective.


More information about the webkit-reviews mailing list