[webkit-reviews] review granted: [Bug 195190] Web Inspector: system accent color follow-ups : [Attachment 363284] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 22:17:27 PST 2019


Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 195190: Web Inspector: system accent color follow-ups
https://bugs.webkit.org/show_bug.cgi?id=195190

Attachment 363284: Patch

https://bugs.webkit.org/attachment.cgi?id=363284&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 363284
  --> https://bugs.webkit.org/attachment.cgi?id=363284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363284&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css:73
> +	   filter: brightness(1.35);

Nice!

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css:45
> +    background-color: var(--selected-text-background-color) !important;

This is almost too light now.  It makes it harder to notice for small record
bars.  Can you darken it a bit?


More information about the webkit-reviews mailing list