[webkit-reviews] review granted: [Bug 195344] Add a platform define for UIColor system colors : [Attachment 363710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 19:10:48 PST 2019

Daniel Bates <dbates at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 195344: Add a platform define for UIColor system colors

Attachment 363710: Patch


--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 363710
  --> https://bugs.webkit.org/attachment.cgi?id=363710

View in context: https://bugs.webkit.org/attachment.cgi?id=363710&action=review

>> Source/WebKit/UIProcess/ios/WKPasswordView.mm:110
>>	[_scrollView setBackgroundColor:[UIColor
> Ok as is, but if you want to be a nice guy you could fix up this line up for
all Apple Engineers (including me!). Search radars on Andy Estes whose title
contains groupTableView.... or poke Andy with a stick (I tried but it wasn’t
sharp enough ;))

Actually, depending on when SYSTEM COLORS is enabled you may have worked around
the issue I am referring too at least for this callsite.... still applicable
To othe call sites.

More information about the webkit-reviews mailing list