[webkit-reviews] review granted: [Bug 195339] op_switch_char broken for rope strings after JSRopeString layout rewrite : [Attachment 363681] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 195339: op_switch_char broken for rope strings after JSRopeString layout
rewrite
https://bugs.webkit.org/show_bug.cgi?id=195339

Attachment 363681: patch

https://bugs.webkit.org/attachment.cgi?id=363681&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 363681
  --> https://bugs.webkit.org/attachment.cgi?id=363681
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363681&action=review

r=me with a comment.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1792
>      loadp JSString::m_fiber[t0], t0

Why not using `t1` for fiber0? Then, I think we do not need to add `move`.