[webkit-reviews] review granted: [Bug 195318] Web Inspector: Attempting to select records in the bottom 16px of the timeline overview graph fails : [Attachment 363617] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 195318: Web Inspector: Attempting to select records in the bottom 16px of
the timeline overview graph fails
https://bugs.webkit.org/show_bug.cgi?id=195318

Attachment 363617: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=363617&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 363617
  --> https://bugs.webkit.org/attachment.cgi?id=363617
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=363617&action=review

rs=me

>>> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:541
>>> +	     this.element.classList.toggle("has-scrollbar",
this._scrollContainerElement.clientHeight <= 1);
>> 
>> Am I misreading this, or should we flip the `<=` to be a `>`?  We only
`has-scrollbar` when the height is `<= 1`?  Wouldn't the scrollbar make the
height larger, or am I thinking backwards?
> 
> When there is no scrollbar the height is 16.
> When there is a scrollbar the height is 1.
> 
> This was tested with overlay scrollbars always on.

Rather than have this be repeated in multiple places, I'd rather you have a
separate function (possibly in Utilities.js) that does this logic.