[webkit-reviews] review requested: [Bug 195337] [JSC] Should check exception for JSString::toExistingAtomicString : [Attachment 363672] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has asked  for review:
Bug 195337: [JSC] Should check exception for JSString::toExistingAtomicString
https://bugs.webkit.org/show_bug.cgi?id=195337

Attachment 363672: Patch

https://bugs.webkit.org/attachment.cgi?id=363672&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 363672
  --> https://bugs.webkit.org/attachment.cgi?id=363672
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363672&action=review

> Source/JavaScriptCore/dfg/DFGOperations.cpp:693
> +		   RETURN_IF_EXCEPTION(scope, encodedJSValue());

encodedJSValue() => { } ?

> Source/JavaScriptCore/runtime/JSString.cpp:273
> +	       RELEASE_AND_RETURN(scope, existingAtomicString);

hmmm, why do you need to release here?

> Source/JavaScriptCore/runtime/JSString.cpp:280
> +	       RELEASE_AND_RETURN(scope, existingAtomicString);

ditto

> Source/JavaScriptCore/runtime/JSString.cpp:284
> +    RELEASE_AND_RETURN(scope, nullptr);

ditto