[webkit-reviews] review granted: [Bug 195324] Web Inspector: Canvas: remove event listeners once a recording is ready : [Attachment 363626] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 10:58:28 PST 2019


Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195324: Web Inspector: Canvas: remove event listeners once a recording is
ready
https://bugs.webkit.org/show_bug.cgi?id=195324

Attachment 363626: Patch

https://bugs.webkit.org/attachment.cgi?id=363626&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 363626
  --> https://bugs.webkit.org/attachment.cgi?id=363626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363626&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Recording.js:536
> +	   this._swizzle = null;

Style: this can go after this._processing = false. I don't think it's necessary
to separate these by group.


More information about the webkit-reviews mailing list