[webkit-reviews] review granted: [Bug 195268] iOS: Using ⌥ to scroll horizontally is no different than arrow key : [Attachment 363496] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 195268: iOS: Using ⌥ to scroll horizontally is no different than arrow key
https://bugs.webkit.org/show_bug.cgi?id=195268

Attachment 363496: Patch

https://bugs.webkit.org/attachment.cgi?id=363496&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 363496
  --> https://bugs.webkit.org/attachment.cgi?id=363496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363496&action=review

> Source/WebKit/ChangeLog:3
> +	   iOS: Using ⥠to scroll horizontally is no different than arrow key

Should this comment be ASCII only?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4428
> +	   return directionIsHorizontal ? documentSize.width :
documentSize.height;

We could have a helper function that converted ScrollingDirection + CGSize to
the right output. Then it could be used in WKKeyboardScrollingAnimator.mm
'distanceForIncrement', too.

But not today.