[webkit-reviews] review denied: [Bug 195310] Web Inspector: Protocol: add type checking when commands are called via invoke : [Attachment 363596] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 5 09:18:59 PST 2019
Brian Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195310: Web Inspector: Protocol: add type checking when commands are called
via invoke
https://bugs.webkit.org/show_bug.cgi?id=195310
Attachment 363596: Patch
https://bugs.webkit.org/attachment.cgi?id=363596&action=review
--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 363596
--> https://bugs.webkit.org/attachment.cgi?id=363596
Patch
Good change but.. it needs to be tested. Please update
inspector-backend-invocation-return-value.html to exercise the invoke() code
paths.
More information about the webkit-reviews
mailing list