[webkit-reviews] review granted: [Bug 195315] MockLibWebRTCPeerConnection is leaking some session description : [Attachment 363606] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 02:05:04 PST 2019


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted  review:
Bug 195315: MockLibWebRTCPeerConnection is leaking some session description
https://bugs.webkit.org/show_bug.cgi?id=195315

Attachment 363606: Patch

https://bugs.webkit.org/attachment.cgi?id=363606&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 363606
  --> https://bugs.webkit.org/attachment.cgi?id=363606
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363606&action=review

r=me

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:214
> +void
MockLibWebRTCPeerConnection::SetLocalDescription(webrtc::SetSessionDescriptionO
bserver* observer, webrtc::SessionDescriptionInterface* description)

Nit: Use `sessionDescription` like SetRemoteDescription()?


More information about the webkit-reviews mailing list