[webkit-reviews] review granted: [Bug 195299] Web Inspector: REGRESSION(r242118): WI.ScopeBar missing background : [Attachment 363571] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195299: Web Inspector: REGRESSION(r242118): WI.ScopeBar missing background
https://bugs.webkit.org/show_bug.cgi?id=195299

Attachment 363571: Patch

https://bugs.webkit.org/attachment.cgi?id=363571&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363571
  --> https://bugs.webkit.org/attachment.cgi?id=363571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363571&action=review

rs=me Sounds good to me.

> Source/WebInspectorUI/ChangeLog:9
> +	   use CSS variables instead. Divides the variables into three
categories:

I only see 2 groups, default and override. I don't see "actual".

> Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css:98
> +    vertical-align: -4px;

How is this calculated? Just adjusting until it looks nice?

> Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:-129
> -.scope-bar > li:matches(.selected, :active) {
> -    transition-duration: 75ms;
> -}

Heh, so we aren't transitioning anything?