[webkit-reviews] review granted: [Bug 195295] [ContentChangeObserver] Introduce fixed duration content observation : [Attachment 363557] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195295: [ContentChangeObserver] Introduce fixed duration content
observation
https://bugs.webkit.org/show_bug.cgi?id=195295

Attachment 363557: Patch

https://bugs.webkit.org/attachment.cgi?id=363557&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 363557
  --> https://bugs.webkit.org/attachment.cgi?id=363557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363557&action=review

> Source/WebCore/ChangeLog:10
> +	   It helps finding content changes when they are triggred by nested
timers (using a 32ms window). Currently nested timers get dropped on the floor
and
> +	   we stop observing for content changes before they get fired. 

Maybe some words about what web pages are trying to do.

> Source/WebCore/page/ios/ContentChangeObserver.h:132
> +	   InstalledFixedObservationTimeWindow,

Started?

> Source/WebCore/page/ios/ContentChangeObserver.h:133
> +	   RemovedFixedObservationTimeWindow

Ended