[webkit-reviews] review granted: [Bug 195059] Web Inspector: Canvas: protocol error on first open : [Attachment 363426] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 4 11:59:44 PST 2019
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195059: Web Inspector: Canvas: protocol error on first open
https://bugs.webkit.org/show_bug.cgi?id=195059
Attachment 363426: Patch
https://bugs.webkit.org/attachment.cgi?id=363426&action=review
--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363426
--> https://bugs.webkit.org/attachment.cgi?id=363426
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=363426&action=review
r=me
> Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js:104
> + if (WI.targetsAvailable()) {
Is this necessary? When no targets are available, WI.targets should be an empty
list safe to iterate.
More information about the webkit-reviews
mailing list