[webkit-reviews] review granted: [Bug 195238] Fix crashes when NetworkResourceLoader/NetworkLoadChecker are destroyed during HTTPS upgrade check : [Attachment 363534] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 11:54:35 PST 2019


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 195238: Fix crashes when NetworkResourceLoader/NetworkLoadChecker are
destroyed during HTTPS upgrade check
https://bugs.webkit.org/show_bug.cgi?id=195238

Attachment 363534: Patch

https://bugs.webkit.org/attachment.cgi?id=363534&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 363534
  --> https://bugs.webkit.org/attachment.cgi?id=363534
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363534&action=review

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:244
> +	       if (!weakThis)

Personally, I would have put this below the if (!result.has_value()) check so
that we may return a more accurate exception when we already have one.


More information about the webkit-reviews mailing list