[webkit-reviews] review granted: [Bug 195250] [JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS : [Attachment 363431] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 195250: [JSC] Make Reflect lazily-allocated by dropping @Reflect references
from builtin JS
https://bugs.webkit.org/show_bug.cgi?id=195250

Attachment 363431: Patch

https://bugs.webkit.org/attachment.cgi?id=363431&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 363431
  --> https://bugs.webkit.org/attachment.cgi?id=363431
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363431&action=review

> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:286
> +EncodedJSValue JSC_HOST_CALL objectConstructorOwnKeys(ExecState* exec)

Why not just make it a global function? I feel like we tend to have private
properties reflect their public ones. But there is no corresponding public
property here.