[webkit-reviews] review denied: [Bug 192495] Range.getBoundingClientRect() returns wrong size when started before a br tag. : [Attachment 363508] Bypass simpleLineLayout for text that has siblings

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has denied  review:
Bug 192495: Range.getBoundingClientRect() returns wrong size when started
before a br tag.
https://bugs.webkit.org/show_bug.cgi?id=192495

Attachment 363508: Bypass simpleLineLayout for text that has siblings

https://bugs.webkit.org/attachment.cgi?id=363508&action=review




--- Comment #8 from zalan <zalan at apple.com> ---
Comment on attachment 363508
  --> https://bugs.webkit.org/attachment.cgi?id=363508
Bypass simpleLineLayout for text that has siblings

View in context: https://bugs.webkit.org/attachment.cgi?id=363508&action=review

> Source/WebCore/rendering/RenderText.cpp:1335
> +    if (!is<RenderBlockFlow>(*parent()) || parent()->firstChild() !=
parent()->lastChild())

We shouldn't need to land changes like this (papering over instead of
addressing the actual issue) in normal circumstances. I'd rather have the
correct fix instead.