[webkit-reviews] review granted: [Bug 195263] Rid the world of WK_API_ENABLED : [Attachment 363474] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 195263: Rid the world of WK_API_ENABLED
https://bugs.webkit.org/show_bug.cgi?id=195263

Attachment 363474: Patch

https://bugs.webkit.org/attachment.cgi?id=363474&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 363474
  --> https://bugs.webkit.org/attachment.cgi?id=363474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363474&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:-732
> -#else
> -    return nil;

This method still needs to return something.

> Source/WebKit/UIProcess/API/Cocoa/WKPreviewActionItem.mm:29
> +#if TARGET_OS_IPHONE

PLATFORM(MAC)?

> Source/WebKit/UIProcess/API/Cocoa/_WKGeolocationPosition.mm:29
> +#if TARGET_OS_IPHONE

PLATFORM(IOS_FAMILY)?