[webkit-reviews] review granted: [Bug 195169] [WPE] Enable web process sandbox : [Attachment 363324] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 195169: [WPE] Enable web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=195169

Attachment 363324: Patch

https://bugs.webkit.org/attachment.cgi?id=363324&action=review




--- Comment #12 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 363324
  --> https://bugs.webkit.org/attachment.cgi?id=363324
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363324&action=review

I don’t know a lot about GTK or WPE, but felt this patch was sane. I do know
about bubble wrap (the packaging stuff not the bwrap executable).

> Source/WebKit/PlatformWPE.cmake:19
> +add_definitions(-DLIBDIR="${LIB_INSTALL_DIR}")

A “why”? for the ignorant in the change log would be nice :)

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:671
> +#if ENABLE(NETSCAPE_PLUGIN_API)

There’s something about this launcher’s name I really like... could it be
BUBBLEWRAP! :D Yes, that’s what it is.

> Source/cmake/BubblewrapSandboxChecks.cmake:4
> +	   message(FATAL_ERROR "bwrap executable is needed for
ENABLE_BUBBLEWRAP_SANDBOX")

Bubblewrap sandbox <— I like it