[webkit-reviews] review granted: [Bug 195253] Retire legacy dtoa function and DecimalNumber class : [Attachment 363457] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 195253: Retire legacy dtoa function and DecimalNumber class
https://bugs.webkit.org/show_bug.cgi?id=195253

Attachment 363457: Patch

https://bugs.webkit.org/attachment.cgi?id=363457&action=review




--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 363457
  --> https://bugs.webkit.org/attachment.cgi?id=363457
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363457&action=review

> Source/WTF/wtf/JSONValues.cpp:677
> +	   else
> +	       output.appendECMAScriptNumber(m_value.number);

Nice.

> Source/WebCore/css/CSSPrimitiveValue.cpp:1015
> +	   return "attr(" + String(m_value.string) + ')';

Ok as-is. Could write using uniform initializer syntax.

> LayoutTests/fast/css/large-value-csstext-expected.txt:4
>
-100000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000%
>
-0.0000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000
000000000000009%
> +1e+254%
> +9e-249%

What nonsense we were emitting. Have to ask though, are these results
compatible with other browsers? Closer to other browsers? Farther from?