[webkit-reviews] review granted: [Bug 179053] Consider supporting the `referrerpolicy` attribute. : [Attachment 363456] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 179053: Consider supporting the `referrerpolicy` attribute.
https://bugs.webkit.org/show_bug.cgi?id=179053

Attachment 363456: Patch

https://bugs.webkit.org/attachment.cgi?id=363456&action=review




--- Comment #42 from Darin Adler <darin at apple.com> ---
Comment on attachment 363456
  --> https://bugs.webkit.org/attachment.cgi?id=363456
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363456&action=review

Looks fine to me; worried about that question about exposing the attribute when
the feature is turned off.

> Source/WebCore/html/HTMLIFrameElement.cpp:141
> +    return { };

Could put an ASSERT_NOT_REACHED() here too. Very unimportant since it’s not
really a practical possibility at all.