[webkit-reviews] review granted: [Bug 195004] -Wformat error in SharedBuffer::tryCreateArrayBuffer : [Attachment 362903] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 195004: -Wformat error in SharedBuffer::tryCreateArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=195004

Attachment 362903: Patch

https://bugs.webkit.org/attachment.cgi?id=362903&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 362903
  --> https://bugs.webkit.org/attachment.cgi?id=362903
Patch

This seems fine. if we did need to log the result of sizeof there are three
traditional fixes:

1) add a type cast to some known type
2) put in a local variable or constant of a known type
3) stringify the constant into the literal directly rather than using printf
formatting to insert it