[webkit-reviews] review granted: [Bug 195255] Remove some more unused 32-bit code : [Attachment 363447] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 2 23:45:17 PST 2019

Darin Adler <darin at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 195255: Remove some more unused 32-bit code

Attachment 363447: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 363447
  --> https://bugs.webkit.org/attachment.cgi?id=363447

View in context: https://bugs.webkit.org/attachment.cgi?id=363447&action=review

Seems super-unlikely it’s caused by this patch, but clearly the "using
namespace WebCore" needs to be removed from
Source/WebKit/Shared/Plugins/unix/PluginSearchPath.cpp, the file doesn’t use
anything form WebCore.

>> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:-472
>> -#if defined(__LP64__) && __LP64__
> I think this one needs to stay, if this code is built for Windows.

Looks like the file is included in the Windows build, not sure about this
particular line of code.

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:-54
> -#ifdef __LP64__
>  #define URefCon void*
> -#else
> -#define URefCon UInt32
> -#endif

There’s no use of URefCon so we can just delete this all.

> Source/WebKit/Shared/mac/WebEventFactory.mm:360
>      double force = 0;

Should just define this below where it’s initialized.

More information about the webkit-reviews mailing list