[webkit-reviews] review denied: [Bug 195178] Native text selection UI is incorrectly suppressed in Microsoft Visio : [Attachment 363401] WIP

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 195178: Native text selection UI is incorrectly suppressed in Microsoft
Visio
https://bugs.webkit.org/show_bug.cgi?id=195178

Attachment 363401: WIP

https://bugs.webkit.org/attachment.cgi?id=363401&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 363401
  --> https://bugs.webkit.org/attachment.cgi?id=363401
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=363401&action=review

> Source/WebCore/ChangeLog:9
> +	   Currently, our heuristics for detecting hidden editable areas
attempts to search for empty parent renderers with

heuristics...attempts -> heuristics...attempt

> Source/WebCore/rendering/RenderObject.cpp:1563
> +	   bool isOverflowHidden = style.overflowX() == Overflow::Hidden ||
style.overflowY() == Overflow::Hidden;
> +	   if (isOverflowHidden && !container->isDocumentElementRenderer() &&
!container->isBody() && container->contentSize().isEmpty())
> +	       return true;
> +

I think this code needs to be rewritten in terms of
RenderLayer::clipRectRelativeToAncestor() or something similar. These are
questions you ask of the RenderLayer rather than trying to compute yourself,
which is fraught with danger.