[webkit-reviews] review granted: [Bug 195240] [ContentChangeObserver] Move away from WKContentChange values : [Attachment 363409] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195240: [ContentChangeObserver] Move away from WKContentChange values
https://bugs.webkit.org/show_bug.cgi?id=195240

Attachment 363409: Patch

https://bugs.webkit.org/attachment.cgi?id=363409&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 363409
  --> https://bugs.webkit.org/attachment.cgi?id=363409
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363409&action=review

> Source/WebCore/ChangeLog:9
> +	   This is in preparation for moving towards a state machine like
implementation.

state machine-like

> Source/WebCore/page/ios/ContentChangeObserver.cpp:133
> +	   LOG(ContentObservation, "stopObservingStyleRecalc: notify the
pending synthetic click handler.");

Mentioning synthetic clicks here indicates a layering problem, as we talked
about.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:137
> +    LOG(ContentObservation, "stopObservingStyleRecalc: can't decided it
yet.");

"can't decided it" ?

> Source/WebCore/page/ios/ContentChangeObserver.cpp:193
> +bool ContentChangeObserver::hasDeterminedState() const

So "determined" as an adjective means "intent on" as in "he was very
determined". This should use "determinate", meaning "fixed" or "settled".