[webkit-reviews] review granted: [Bug 195142] Fixed makeString(float) to do shortest-form serialization without first converting to double : [Attachment 363411] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 195142: Fixed makeString(float) to do shortest-form serialization without
first converting to double
https://bugs.webkit.org/show_bug.cgi?id=195142

Attachment 363411: Patch

https://bugs.webkit.org/attachment.cgi?id=363411&action=review




--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 363411
  --> https://bugs.webkit.org/attachment.cgi?id=363411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363411&action=review

This patch is ok as-is. I’m was torn during review between pointing out style
issues in the dtoa code or not because its code we brought over. For the lines
you touched we could go farther towards conforming to the guide

> Source/WTF/ChangeLog:12
> +	   marked the constructor explicit, removed types used only fir
arguments for

fir

> Source/WTF/wtf/dtoa.h:30
> +using DtoaBuffer = std::array<char, 80>;

Nice.