[webkit-reviews] review granted: [Bug 195105] Web Inspector: Sources: breakpoints should be disabled when an audit is running : [Attachment 363105] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195105: Web Inspector: Sources: breakpoints should be disabled when an
audit is running
https://bugs.webkit.org/show_bug.cgi?id=195105

Attachment 363105: Patch

https://bugs.webkit.org/attachment.cgi?id=363105&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363105
  --> https://bugs.webkit.org/attachment.cgi?id=363105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663
> +	       let stopAuditButton = document.createElement("button");

In the Debugger tab this is a "a" not a "button". Why the change?

>
Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665
> +	       stopAuditButton.addEventListener("click", () => {

Nit: Don't you prefer putting `event` in the param?