[webkit-reviews] review granted: [Bug 195235] [JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX : [Attachment 363390] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 195235: [JSC] Fix FTL build on ARM32_64 by adding stubs for
JSRopeString::offsetOfXXX
https://bugs.webkit.org/show_bug.cgi?id=195235

Attachment 363390: Patch

https://bugs.webkit.org/attachment.cgi?id=363390&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 363390
  --> https://bugs.webkit.org/attachment.cgi?id=363390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review

> Source/JavaScriptCore/runtime/JSString.h:567
> +    static ptrdiff_t offsetOfFlags() { return 0; }
> +    static ptrdiff_t offsetOfFiber1Lower() { return 0; }
> +    static ptrdiff_t offsetOfFiber1Upper() { return 0; }
> +    static ptrdiff_t offsetOfFiber2Lower() { return 0; }
> +    static ptrdiff_t offsetOfFiber2Upper() { return 0; }

please ASSERT_NOT_REACHED or similar.