[webkit-reviews] review granted: [Bug 195229] Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier : [Attachment 363389] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 195229: Add setters on WKWebsiteDataStore for
sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
https://bugs.webkit.org/show_bug.cgi?id=195229

Attachment 363389: Patch

https://bugs.webkit.org/attachment.cgi?id=363389&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 363389
  --> https://bugs.webkit.org/attachment.cgi?id=363389
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363389&action=review

r=me but please check EWS.

> Source/WebKit/ChangeLog:12
> +	   Functionality verified by manual testing.  See radar.

extra space.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:203
> +    const String& sourceApplicationBundleIdentifier() { return
m_sourceApplicationBundleIdentifier; }

const

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:206
> +    const String& sourceApplicationSecondaryIdentifier() { return
m_sourceApplicationSecondaryIdentifier; }

const