[webkit-reviews] review denied: [Bug 192681] Web Inspector: Elements tab: multiple selection lost after navigating to another tab : [Attachment 362563] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 192681: Web Inspector: Elements tab: multiple selection lost after
navigating to another tab
https://bugs.webkit.org/show_bug.cgi?id=192681

Attachment 362563: Patch

https://bugs.webkit.org/attachment.cgi?id=362563&action=review




--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 362563
  --> https://bugs.webkit.org/attachment.cgi?id=362563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362563&action=review

>>> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:195
>>> +			 treeElement = treeElement.children.lastValue;
>> 
>> This is a scary assumption to make.	Why don't we pass the actual
`WI.DOMTreeElement` as `elementCloseTag` instead of just a true/false?	That
way, we can retrieve it directly here (e.g.
`treeElement.associatedCloseTagTreeElement`).
> 
> Nice idea. Will change.

r-, as it seems like you're going to make some changes