[webkit-reviews] review granted: [Bug 193806] [PlayStation] Upstream playstation's remote inspector server : [Attachment 362940] Inspector Server

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 193806: [PlayStation] Upstream playstation's remote inspector server
https://bugs.webkit.org/show_bug.cgi?id=193806

Attachment 362940: Inspector Server

https://bugs.webkit.org/attachment.cgi?id=362940&action=review




--- Comment #32 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 362940
  --> https://bugs.webkit.org/attachment.cgi?id=362940
Inspector Server

View in context: https://bugs.webkit.org/attachment.cgi?id=362940&action=review

r=me!

>
Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocketClient.
h:42
> +    RemoteInspectorSocketClient(RemoteInspectorConnectionClient*);

Style: You can make this single argument constructor `explicit`.

>
Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocketClientP
layStation.cpp:48
> +    struct sockaddr_in saServer = { 0 };
> +    saServer.sin_family = AF_INET;

The names in here that are abbreviations are unusual for WebKit style
(`saServer`, `ret`).

Normally I see initialization with memset:

    memset(&saServer, 0, sizeof(struct sockaddr_in));

I'm not sure if the { 0 } alone would be enough.

>
Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocketServer.
h:41
> +    RemoteInspectorSocketServer(RemoteInspectorConnectionClient*);

Style: You can make this single argument constructor `explicit`.

>
Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocketServer.
h:43
> +    bool listenInet(int port);

Not important but if you want you could reduce the type of port throughout this
patch if you want. Most of the time a port is a uint16_t and not exactly an
int. In your patches it ultimately goes into a sockaddr_in.sin_port.