[webkit-reviews] review granted: [Bug 195220] [ContentChangeObserver] Check for pending style recalcs at the end of each timer run. : [Attachment 363362] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195220: [ContentChangeObserver] Check for pending style recalcs at the end
of each timer run.
https://bugs.webkit.org/show_bug.cgi?id=195220

Attachment 363362: Patch

https://bugs.webkit.org/attachment.cgi?id=363362&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 363362
  --> https://bugs.webkit.org/attachment.cgi?id=363362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363362&action=review

> Source/WebCore/ChangeLog:10
> +	   when in addition to this style recalc scheduling, something later
(thouhg during the same timer firing) triggers a sync style recalc.

thouhg

> Source/WebCore/page/ios/ContentChangeObserver.cpp:99
> +    auto inDeterminedState = observedContentChange ==
WKContentVisibilityChange || (!countOfObservedDOMTimers() &&
observedContentChange == WKContentNoChange && !hasPendingStyleRecalc);	

hasDeterminedState