[webkit-reviews] review granted: [Bug 195221] [JSC] Use runtime calls for DFG MakeRope if !CPU(ADDRESS64) : [Attachment 363358] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 195221: [JSC] Use runtime calls for DFG MakeRope if !CPU(ADDRESS64)
https://bugs.webkit.org/show_bug.cgi?id=195221

Attachment 363358: Patch

https://bugs.webkit.org/attachment.cgi?id=363358&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 363358
  --> https://bugs.webkit.org/attachment.cgi?id=363358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363358&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:13400
> +    Edge edges[3] = {
> +	   node->child1(),
> +	   node->child2(),
> +	   node->child3()
> +    };

This is only used by the CPU(ADDRESS64) case.  Can you move it in there?