[webkit-reviews] review granted: [Bug 194612] EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe : [Attachment 362659] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 12:09:51 PST 2019

Alex Christensen <achristensen at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 194612: EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe

Attachment 362659: Patch


--- Comment #23 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 362659
  --> https://bugs.webkit.org/attachment.cgi?id=362659

View in context: https://bugs.webkit.org/attachment.cgi?id=362659&action=review

Seems good to me.  This simplifies the code quite a bit.  I guess the
motivation was just to make the API test more reliable, right?

> Source/WebKit/Platform/unix/EnvironmentUtilities.cpp:41
> +    auto hasAppended = false;

StringBuilder::isEmpty could be used instead of this additional boolean
tracking the same thing.

More information about the webkit-reviews mailing list