[webkit-reviews] review denied: [Bug 194131] Load events may occur in unexpected order when JS redirects page before subresource load finishes : [Attachment 363333] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 194131: Load events may occur in unexpected order when JS redirects page
before subresource load finishes
https://bugs.webkit.org/show_bug.cgi?id=194131

Attachment 363333: Patch

https://bugs.webkit.org/attachment.cgi?id=363333&action=review




--- Comment #25 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 363333
  --> https://bugs.webkit.org/attachment.cgi?id=363333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363333&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:3895
> +	       m_navigationClient->didFailProvisionalNavigationWithError(*this,
*frame, previousNavigation, { ResourceError::Type::Cancellation },
process->transformHandlesToObjects(userData.object()).get());
> +	   else if (previousState == PageLoadState::State::Committed)
> +	       m_navigationClient->didFailNavigationWithError(*this, *frame,
previousNavigation, { ResourceError::Type::Cancellation },
m_process->transformHandlesToObjects(userData.object()).get());

I don't think invoking clients in this case is backwards compatible change.
Please make this change in such a way that it won't affect Apple maintained
ports (macOS / iOS).