[webkit-reviews] review granted: [Bug 188318] [WinCairo] Enable service worker : [Attachment 363293] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 09:21:21 PST 2019


youenn fablet <youennf at gmail.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 188318: [WinCairo] Enable service worker
https://bugs.webkit.org/show_bug.cgi?id=188318

Attachment 363293: Patch

https://bugs.webkit.org/attachment.cgi?id=363293&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 363293
  --> https://bugs.webkit.org/attachment.cgi?id=363293
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363293&action=review

> Tools/DumpRenderTree/DumpRenderTreePrefix.h:39
>  #if OS(WINDOWS)

Should it be PLATFORM(WIN) here as well?

> Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h:51
>  #if OS(WINDOWS)

Should it be PLATFORM(WIN) here as well?


More information about the webkit-reviews mailing list